Re: [RFC PATCH 2/3] lib/list_batch, x86: Enable list insertion/deletion batching in x86-64
From: Peter Zijlstra
Date: Wed Jan 27 2016 - 11:39:06 EST
On Tue, Jan 26, 2016 at 01:44:13PM -0800, Andi Kleen wrote:
> Waiman Long <Waiman.Long@xxxxxxx> writes:
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 330e738..443e41d 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -42,6 +42,7 @@ config X86
> > select ARCH_SUPPORTS_NUMA_BALANCING if X86_64
> > select ARCH_USE_BUILTIN_BSWAP
> > select ARCH_USE_CMPXCHG_LOCKREF if X86_64
> > + select ARCH_USE_LIST_BATCHING if X86_64
>
> I would make it unconditional. The code is simple enough
> and shouldn't have drawbacks on smaller systems.
I agree with the sentiment but would like to see a benchmark done on a
small system to verify all the same.