Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

From: Jonathan Cameron
Date: Wed Jan 27 2016 - 12:23:56 EST

On 27 January 2016 16:31:42 GMT+00:00, Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote:
>On Sat, Jan 16, 2016 at 2:07 PM, Jonathan Cameron <jic23@xxxxxxxxxx>
>> On 14/01/16 16:25, Daniel Baluta wrote:
>>> The driver has sysfs readings with runtime PM support for power
>>> It also offers buffer support that can be used together with IIO
>>> triggers.
>>> Datasheet can be found here:
>>> Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxxxx>
>Thanks for the feedback! Few questions below.
>> The hwmon compatibility stuff has been covered by others so I'll just
>> you'll sort that out :)
>> Various bits and bobs inline.
>Do you think it is worth to have both of the drivers in parallel for a
>period until
>we figure out that everything is correct? The IIO config symbol can be
>only hwmon symbol is not enabled?
Yes. (That was easy)
>>> +struct ads1015_data {
>> I was a little suprised to see both the i2c_client and regmap in
>> Could use regmap_get_device for most if not all uses in here of the
>> client pointer..
>That's a good point. Anyhow, there is no single instance of
>in the IIO tree. I counted at least 4 drivers where we could use it.
>Do you think
>is there a great benefit from using it?
I only came across it here by thinking surely there was a better way!

>This will be a nice change for Linux kernel outreachy applicants :).
>I'm sure they will
>love to work on it.
>>> + struct i2c_client *client;
>>> + struct regmap *regmap;
>> You only use buffer[0] that I can see...
>The rest should be for the timestamp and I will fix it :).

Sent from my Android device with K-9 Mail. Please excuse my brevity.