Re: [RFC PATCH v2 1/3] getcpu_cache system call: cache CPU number of running thread

From: Thomas Gleixner
Date: Wed Jan 27 2016 - 12:36:12 EST


On Wed, 27 Jan 2016, Mathieu Desnoyers wrote:
> ----- On Jan 27, 2016, at 12:22 PM, Thomas Gleixner tglx@xxxxxxxxxxxxx wrote:
> Sounds fair. What is the recommended typing for "ptr" then ?
> uint32_t ** or uint32_t * ?
>
> It would be expected to pass a "uint32_t *" for the set
> operation, but the "get" operation requires a "uint32_t **".

Well, you can't change the types depending on the opcode, so you need to stick
with **.

> Also, I'd be tempted to put the GET/SET operation selector as
> a first parameter.

Makes sense.

Thanks,

tglx