Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output

From: Javier Martinez Canillas
Date: Wed Jan 27 2016 - 19:00:37 EST

Hello Krzysztof,

On 01/27/2016 03:46 AM, Krzysztof Kozlowski wrote:
Cleanup of entire driver of its dmesg output:
1. Remove printing of the function name, because printing device name is
sufficient. This also makes the dev_err()-like functions more compact
and readable (not need of line break).
2. Lower from info to debug printing of each RTC interrupt (no need to
make noise on each alarm).
3. Remove dev_info() at beginning of probe because a message is already
always printed by either probe failure or from registering the RTC
device as /dev/rtcX.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Best regards,
Javier Martinez Canillas
Open Source Group
Samsung Research America