Re: [PATCH V2 2/4] gpio: gpio-f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO GPIOLIB support

From: kbuild test robot
Date: Thu Jan 28 2016 - 04:56:19 EST


Hi Peter,

[auto build test ERROR on gpio/for-next]
[also build test ERROR on v4.5-rc1 next-20160128]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url: https://github.com/0day-ci/linux/commits/Peter-Hung/Transform-Fintek-PCIE-driver-from-8250-to-MFD/20160128-172929
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: i386-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All error/warnings (new ones prefixed by >>):

In file included from include/linux/list.h:8:0,
from include/linux/kobject.h:20,
from include/linux/device.h:17,
from include/linux/platform_device.h:14,
from drivers/gpio/gpio-f81504.c:18:
drivers/gpio/gpio-f81504.c: In function 'f81504_gpio_direction_in':
>> drivers/gpio/gpio-f81504.c:41:56: error: 'struct gpio_chip' has no member named 'dev'
struct platform_device *pdev = to_platform_device(chip->dev);
^
include/linux/kernel.h:841:49: note: in definition of macro 'container_of'
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
^
>> drivers/gpio/gpio-f81504.c:41:33: note: in expansion of macro 'to_platform_device'
struct platform_device *pdev = to_platform_device(chip->dev);
^
drivers/gpio/gpio-f81504.c: In function 'f81504_gpio_direction_out':
drivers/gpio/gpio-f81504.c:63:56: error: 'struct gpio_chip' has no member named 'dev'
struct platform_device *pdev = to_platform_device(chip->dev);
^
include/linux/kernel.h:841:49: note: in definition of macro 'container_of'
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
^
drivers/gpio/gpio-f81504.c:63:33: note: in expansion of macro 'to_platform_device'
struct platform_device *pdev = to_platform_device(chip->dev);
^
drivers/gpio/gpio-f81504.c: In function 'f81504_gpio_get_direction':
drivers/gpio/gpio-f81504.c:104:56: error: 'struct gpio_chip' has no member named 'dev'
struct platform_device *pdev = to_platform_device(chip->dev);
^
include/linux/kernel.h:841:49: note: in definition of macro 'container_of'
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
^
drivers/gpio/gpio-f81504.c:104:33: note: in expansion of macro 'to_platform_device'
struct platform_device *pdev = to_platform_device(chip->dev);
^
drivers/gpio/gpio-f81504.c: In function 'f81504_gpio_get':
drivers/gpio/gpio-f81504.c:122:56: error: 'struct gpio_chip' has no member named 'dev'
struct platform_device *pdev = to_platform_device(chip->dev);
^
include/linux/kernel.h:841:49: note: in definition of macro 'container_of'
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
^
drivers/gpio/gpio-f81504.c:122:33: note: in expansion of macro 'to_platform_device'
struct platform_device *pdev = to_platform_device(chip->dev);
^
drivers/gpio/gpio-f81504.c: In function 'f81504_gpio_probe':
drivers/gpio/gpio-f81504.c:212:10: error: 'struct gpio_chip' has no member named 'dev'
gc->chip.dev = &pdev->dev;
^

coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpio/gpio-f81504.c:246:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

vim +41 drivers/gpio/gpio-f81504.c

12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License
16 * along with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
> 18 #include <linux/platform_device.h>
19 #include <linux/gpio.h>
20 #include <linux/pci.h>
21 #include <linux/mfd/f81504.h>
22
23 struct f81504_gpio_chip {
24 struct gpio_chip chip;
25 struct mutex locker;
26 u8 idx;
27 u8 save_out_en;
28 u8 save_drive_en;
29 u8 save_value;
30 };
31
32 static struct f81504_gpio_chip *gpio_to_f81504_chip(struct gpio_chip *chip)
33 {
34 return container_of(chip, struct f81504_gpio_chip, chip);
35 }
36
37 static int f81504_gpio_direction_in(struct gpio_chip *chip, unsigned offset)
38 {
39 u8 tmp;
40 struct f81504_gpio_chip *gc = gpio_to_f81504_chip(chip);
> 41 struct platform_device *pdev = to_platform_device(chip->dev);
42 struct pci_dev *pci_dev = to_pci_dev(pdev->dev.parent);
43
44 mutex_lock(&gc->locker);

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data