Re: [PATCH] drm/amdgpu: fix non-ANSI declaration of amdgpu_amdkfd_gfx_*_get_functions()

[Oded Gabbay]

On Fri, Jan 22, 2016 at 7:35 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> amdgpu_amdkfd_gfx_7_get_functions and amdgpu_amdkfd_gfx_8_0_get_functions
> have no parameters, so use the normal void parameter convention to make
> them  match their prototypes in the header file
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c
> index 0e13763..362bedc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c
> @@ -154,7 +154,7 @@ static const struct kfd2kgd_calls kfd2kgd = {
>         .get_fw_version = get_fw_version
>  };
>
> -struct kfd2kgd_calls *amdgpu_amdkfd_gfx_7_get_functions()
> +struct kfd2kgd_calls *amdgpu_amdkfd_gfx_7_get_functions(void)
>  {
>         return (struct kfd2kgd_calls *)&kfd2kgd;
>  }
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
> index 79fa5c7..04b744d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
> @@ -115,7 +115,7 @@ static const struct kfd2kgd_calls kfd2kgd = {
>         .get_fw_version = get_fw_version
>  };
>
> -struct kfd2kgd_calls *amdgpu_amdkfd_gfx_8_0_get_functions()
> +struct kfd2kgd_calls *amdgpu_amdkfd_gfx_8_0_get_functions(void)
>  {
>         return (struct kfd2kgd_calls *)&kfd2kgd;
>  }
> --
> 2.7.0.rc3
>

Thanks,
Applied to my -next tree

Oded