Re: [PATCH] ipv4: ipconfig: avoid unused ic_proto_used symbol

From: Sergei Shtylyov
Date: Thu Jan 28 2016 - 08:11:56 EST


Hello.

On 1/27/2016 4:53 PM, Arnd Bergmann wrote:

When CONFIG_PROC_FS, CONFIG_IP_PNP_BOOTP, CONFIG_IP_PNP_DHCP and
CONFIG_IP_PNP_RARP are all disabled, we get a warning about the
ic_proto_used variable being unused:

net/ipv4/ipconfig.c:146:12: error: 'ic_proto_used' defined but not used [-Werror=unused-variable]

This avoids the warning, but making the definition conditional on

s/but/by/?

whether a dynamic IP configuration protocol is configured. If not,
we know that the value is always zero, so we can optimize away the
variable and all code that depends on it.

Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
[...]

MBR, Sergei