Re: [RFC PATCH 3/6] of: iommu: Increment DT node refcount in of_iommu_set_ops()

From: Robin Murphy
Date: Thu Jan 28 2016 - 12:15:39 EST

On 27/01/16 05:21, Anup Patel wrote:
We are saving pointer to iommu DT node in of_iommu_set_ops()
hence we should increment DT node ref count.

Oh man, shame on whoever wrote that code! :P

Reviewed-by: Robin Murphy <robin.murphy@xxxxxxx>

Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxxxx>
Reviewed-by: Ray Jui <rjui@xxxxxxxxxxxx>
Reviewed-by: Scott Branden <sbranden@xxxxxxxxxxxx>
drivers/iommu/of_iommu.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 60ba238..5fea665 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -110,6 +110,7 @@ void of_iommu_set_ops(struct device_node *np, struct iommu_ops *ops)
if (WARN_ON(!iommu))

+ of_node_get(np);
iommu->np = np;
iommu->ops = ops;