[PATCH 2/2] pmem: Flush cache on unaligned request
From: Toshi Kani
Date: Thu Jan 28 2016 - 13:14:59 EST
arch_memcpy_to_pmem() calls __copy_user_nocache() to copy data
via non-temporal stores. However, __copy_user_nocache() still
performs cached copy when a request is not naturally aligned or
is less then 4 bytes.
Call clflush_cache_range() to flush destination when a request
leads to cached copy.
Signed-off-by: Toshi Kani <toshi.kani@xxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: H. Peter Anvin <hpa@xxxxxxxxx>
Cc: Borislav Petkov <bp@xxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Cc: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx>
---
arch/x86/include/asm/pmem.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/x86/include/asm/pmem.h b/arch/x86/include/asm/pmem.h
index c57fd1e..f135064 100644
--- a/arch/x86/include/asm/pmem.h
+++ b/arch/x86/include/asm/pmem.h
@@ -45,6 +45,17 @@ static inline void arch_memcpy_to_pmem(void __pmem *dst, const void *src,
if (WARN(unwritten, "%s: fault copying %p <- %p unwritten: %d\n",
__func__, dst, src, unwritten))
BUG();
+
+ /*
+ * Flush the caches when the request is not naturally aligned.
+ * Non-temporal stores are not used for unaligned copy.
+ */
+ if (((n >= 8) &&
+ (!IS_ALIGNED((unsigned long)dst, 8) || !IS_ALIGNED(n, 8))) ||
+ ((n < 8) &&
+ (!IS_ALIGNED((unsigned long)dst, 4) || (n != 4)))) {
+ clflush_cache_range(dst, n);
+ }
}
/**