Re: [PATCH 25/31] media: au0828 fix to not call media_device_unregister_entity_notify()

[Shuah Khan]

On 01/28/2016 09:45 AM, Mauro Carvalho Chehab wrote:
> Em Wed,  6 Jan 2016 14:01:54 -0700
> Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> escreveu:
> 
>> entity_notify handlers are removed from media_device_unregister().
>> There is no need to call media_device_unregister_entity_notify()
>> to do that right before calling media_device_unregister().
> 
> Please merge with the patch that added it.

ok

> 
>>
>> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>> ---
>>  drivers/media/usb/au0828/au0828-core.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c
>> index 9497ad1..722e073 100644
>> --- a/drivers/media/usb/au0828/au0828-core.c
>> +++ b/drivers/media/usb/au0828/au0828-core.c
>> @@ -137,8 +137,6 @@ static void au0828_unregister_media_device(struct au0828_dev *dev)
>>  #ifdef CONFIG_MEDIA_CONTROLLER
>>  	if (dev->media_dev &&
>>  		media_devnode_is_registered(&dev->media_dev->devnode)) {
>> -		media_device_unregister_entity_notify(dev->media_dev,
>> -						      &dev->entity_notify);
>>  		media_device_unregister(dev->media_dev);
>>  		media_device_cleanup(dev->media_dev);
>>  		dev->media_dev = NULL;


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978