Re: [PATCH] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL_SSI depending on SoC type

[Lothar WaÃmann]

Hi,

On Thu, 28 Jan 2016 22:30:13 -0800 Nicolin Chen wrote:
> On Fri, Jan 29, 2016 at 06:59:38AM +0100, Lothar WaÃmann wrote:
> > Hi,
> > 
> > On Thu, 28 Jan 2016 23:33:52 +0100 Mark Brown wrote:
> > > On Wed, Jan 20, 2016 at 01:30:38PM +0100, Lothar WaÃmann wrote:
> > > 
> > > > -	select SND_SOC_FSL_SSI
> > > > +	select SND_SOC_FSL_SAI if SOC_IMX6UL
> > > > +	select SND_SOC_FSL_SSI if SOC_IMX6Q || SOC_IMX6SL || SOC_IMX6SX
> > > 
> > > Does this card not work for older i.MXs (which had the same SSI/AUDMUX
> > > combination as the majority of the i.MX6 family) as well?
> > >
> > Our baseboard contains an SGTL5000 codec which is working with
> > i.MX25, i.MX27, i.MX5, i.MX6Q, i.MX6DL with the fsl_ssi and imx-sgtl5000
> > + imx-audmux driver, on i.MX28 with the mxs-saif and mxs-sgtl5000 driver
> > and on i.MX6UL with the fsl_sai + simple-card driver.
> 
> Have you tried fsl-asoc-card to connect SSI/SAI with sgtl5000? If it
> works for you directly, I believe things should be easier for you
> instead of dealing with Kconfig.
>
My patch simply selects the FSL_SAI instead of the FSL_SSI interface for
i.MX6UL since the latter is NOT AVAILABLE on i.MX6UL and thus it doesn't
make any sense to select it on this SoC.

But maybe the select statements should be removed altogether since they
are a case of the frowned-upon "select for user visible symbols".


Lothar WaÃmann