Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2)

From: Arnaldo Carvalho de Melo
Date: Fri Jan 29 2016 - 16:00:22 EST


Em Thu, Jan 28, 2016 at 08:52:25PM +0100, Jiri Olsa escreveu:
> On Thu, Jan 28, 2016 at 09:24:54PM +0900, Namhyung Kim wrote:
>
> SNIP
>
> > > > > The default limit of hist entries is 0 so it basically shows all
> > > > > entries. But default callchain limit is 0.5% so hist entries under
> > > > > 0.5% won't show callchains.
> > > >
> > > > Btw, I changed it to 0.005% in this patchset. Did you apply all the
> > > > patches and run 'perf report' with default value?
> > >
> > > yep, I had it and then reverted ;-) but I made typo
> > > in the previous email.. what I meant was:
> > >
> > > also I see extra LINE for entries... ;-)
> >
> > Ah, so you meant the blank lines.. The fix would be like following
>
> yep, tested.. works ;-)

Namhyung, can I try to process this patchkit just by reading these
commends and making the adjustments? Or is there something outstanding
that warrants you to push a v2?

- Arnaldo