Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output

From: Alexandre Belloni
Date: Sun Jan 31 2016 - 07:08:27 EST


On 27/01/2016 at 15:46:11 +0900, Krzysztof Kozlowski wrote :
> Cleanup of entire driver of its dmesg output:
> 1. Remove printing of the function name, because printing device name is
> sufficient. This also makes the dev_err()-like functions more compact
> and readable (not need of line break).
> 2. Lower from info to debug printing of each RTC interrupt (no need to
> make noise on each alarm).
> 3. Remove dev_info() at beginning of probe because a message is already
> always printed by either probe failure or from registering the RTC
> device as /dev/rtcX.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>
> ---
>
> Patch rebased on top of Javier's v4:
> [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support
> http://www.spinics.net/lists/arm-kernel/msg477194.html
>
> Feel free to join with these series.
> ---
> drivers/rtc/rtc-max77686.c | 39 ++++++++++++++-------------------------
> 1 file changed, 14 insertions(+), 25 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com