Re: [PATCH 3/4] x86: signal: unify the sigaltstack check with other arches

From: Andy Lutomirski
Date: Sun Jan 31 2016 - 11:59:09 EST


On Sun, Jan 31, 2016 at 8:24 AM, Stas Sergeev <stsp@xxxxxxx> wrote:
>
> Currently x86's get_sigframe() checks for "current->sas_ss_size"
> to determine whether there is a need to switch to sigaltstack.
> The common practice used by all other arches is to check for
> sas_ss_flags(sp) == 0
>
> This patch makes the code consistent with other arches and also
> allows for the further sigaltstack improvements within this patch serie.

You've duplicate part of the check. That whole block is already
checking !sigstack. Can you remove that now?

--Andy