Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512 UART driver

[Peter Hung]

Hi Andy,

Andy Shevchenko æ 2016/1/29 äå 08:40 åé:
> On Fri, 2016-01-29 at 16:20 +0800, Peter Hung wrote:
> > Hi Andy,
> >
> > Andy Shevchenko æ 2016/1/28 äå 08:04 åé:
> > > On Thu, 2016-01-28 at 17:20 +0800, Peter Hung wrote:
> > > > -	/* Fintek PCI serial cards */
> > > > -	{ PCI_DEVICE(0x1c29, 0x1104), .driver_data =
> > > > pbn_fintek_4 },
> > > > -	{ PCI_DEVICE(0x1c29, 0x1108), .driver_data =
> > > > pbn_fintek_8 },
> > > > -	{ PCI_DEVICE(0x1c29, 0x1112), .driver_data =
> > > > pbn_fintek_12
> > > > },
> > >
> > > Shouldn't you blacklist them in 8250_pci?
> >
> > You are referring to add blacklist instead of remove F81504/508/512
> > code?
>
> No.
>
> >   or add blacklist and remove code?
>
> This one.

ok

> Check what lspci tells you about your device. I'm pretty sure that it
> has Serial Class, which would trigger enumeration in 8250_pci.c if it
> comes first.

I had add log with 8250_pci.c. It really trigger once by 8250_pci.c,
but will failed with serial_pci_guess_board(). So It can be handled by
f81504-core.c. I should add pid/vid to blacklist and comments it'll
be handled by f81504-core.c

Thanks
--
With Best Regards,
Peter Hung