Re: [PATCH 6/9] staging: ion: Set minimum carveout heap allocation order to PAGE_SHIFT

[Laura Abbott]

On 01/29/2016 10:07 PM, John Stultz wrote:
> From: Rajmal Menariya <rajmal.menariya@xxxxxxxxxxxxxx>
>
> In carveout heap, change minimum allocation order from 12 to
> PAGE_SHIFT. After this change each bit in bitmap (genalloc -
> General purpose special memory pool) represents one page size
> memory.
>
> Cc: sprd-ind-kernel-group@xxxxxxxxxxxxxxxx
> Cc: sanjeev.yadav@xxxxxxxxxxxxxx
> Cc: Colin Cross <ccross@xxxxxxxxxxx>
> Cc: Android Kernel Team <kernel-team@xxxxxxxxxxx>
> Cc: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Laura Abbott <labbott@xxxxxxxxxx>
> Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> Signed-off-by: Rajmal Menariya <rajmal.menariya@xxxxxxxxxxxxxx>
> [jstultz: Reworked commit message]
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>

Acked-by: Laura Abbott <labbott@xxxxxxxxxx>

> ---
>   drivers/staging/android/ion/ion_carveout_heap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c
> index 9156d82..e702ce6 100644
> --- a/drivers/staging/android/ion/ion_carveout_heap.c
> +++ b/drivers/staging/android/ion/ion_carveout_heap.c
> @@ -167,7 +167,7 @@ struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data)
>   	if (!carveout_heap)
>   		return ERR_PTR(-ENOMEM);
>
> -	carveout_heap->pool = gen_pool_create(12, -1);
> +	carveout_heap->pool = gen_pool_create(PAGE_SHIFT, -1);
>   	if (!carveout_heap->pool) {
>   		kfree(carveout_heap);
>   		return ERR_PTR(-ENOMEM);