Re: [PATCH] netfilter: nft_ct: define nft_ct_get_eval_counter() only when needed

From: Florian Westphal
Date: Mon Feb 01 2016 - 23:19:18 EST


Eric Biggers <ebiggers3@xxxxxxxxx> wrote:
> This eliminates an "unused function" compiler warning when
> CONFIG_NF_CONNTRACK_LABELS is not defined.
>
> Signed-off-by: Eric Biggers <ebiggers3@xxxxxxxxx>

The nft_ct_get_eval_counter call should've been unconditional.
The #endif placement is wrong:

https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit?id=efaea94aaf0decd55b15aa7068d4d516a352e56e