Re: [PATCH] EDAC, mpc85xx: fix build warning

[Borislav Petkov]

On Tue, Feb 02, 2016 at 08:43:57PM +0530, Sudip Mukherjee wrote:
> another way might be:
> 
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index b7139c1..968c0c0 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -1244,7 +1244,9 @@ static struct platform_driver * const drivers[] = {
>  static int __init mpc85xx_mc_init(void)
>  {
>  	int res = 0;
> +#ifdef CONFIG_FSL_SOC_BOOKE
>  	u32 pvr = 0;
> +#endif

Nah, this is the ugliest of them all. We want less ifdeffery, not more.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.