Re: [PATCH] misc: Move panel driver out of staging

[Greg KH]

On Tue, Feb 02, 2016 at 05:48:56PM +0100, Ksenija StanojeviÄ wrote:
> Hi Greg,
> 
> On Tue, Feb 2, 2016 at 5:23 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote:
> >> Move panel driver from drivers/staging/panel to drivers/misc.
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@xxxxxxxxx>
> >> ---
> >>  drivers/misc/Kconfig                      |  278 ++++
> >>  drivers/misc/Makefile                     |    1 +
> >>  drivers/misc/panel.c                      | 2445 +++++++++++++++++++++++++++++
> >>  drivers/staging/Kconfig                   |    2 -
> >>  drivers/staging/Makefile                  |    1 -
> >>  drivers/staging/panel/Kconfig             |  278 ----
> >>  drivers/staging/panel/Makefile            |    1 -
> >>  drivers/staging/panel/TODO                |    8 -
> >>  drivers/staging/panel/lcd-panel-cgram.txt |   24 -
> >>  drivers/staging/panel/panel.c             | 2445 -----------------------------
> >>  10 files changed, 2724 insertions(+), 2759 deletions(-)
> >>  create mode 100644 drivers/misc/panel.c
> >>  delete mode 100644 drivers/staging/panel/Kconfig
> >>  delete mode 100644 drivers/staging/panel/Makefile
> >>  delete mode 100644 drivers/staging/panel/TODO
> >>  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
> >>  delete mode 100644 drivers/staging/panel/panel.c
> >
> >
> > Can you generate a patch like this with the -M option to git
> > format-patch?
> 
> I tried that but it didn't change anything.

It worked for me:

 drivers/misc/Kconfig                      | 278 ++++++++++++++++++++++++++++++
 drivers/misc/Makefile                     |   1 +
 drivers/{staging/panel => misc}/panel.c   |   0
 drivers/staging/Kconfig                   |   2 -
 drivers/staging/Makefile                  |   1 -
 drivers/staging/panel/Kconfig             | 278 ------------------------------
 drivers/staging/panel/Makefile            |   1 -
 drivers/staging/panel/TODO                |   8 -
 drivers/staging/panel/lcd-panel-cgram.txt |  24 ---
 9 files changed, 279 insertions(+), 314 deletions(-)
 rename drivers/{staging/panel => misc}/panel.c (100%)
 delete mode 100644 drivers/staging/panel/Kconfig
 delete mode 100644 drivers/staging/panel/Makefile
 delete mode 100644 drivers/staging/panel/TODO
 delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt

See the lines that show the file being renamed?

How exactly did you export the patch?

> Also, should panel driver have a separate directory in drivers/misc?

For a single driver, I wouldn't worry about that, putting it in misc/ is fine.
But, you dropped the lcd-panel-cgram.txt file, perhaps you want to keep that
somewhere in Documentation/ ?

thanks,

greg k-h