Re: [PATCH v2 4/5] Add support for deep sleep control.

From: Darren Hart
Date: Tue Feb 02 2016 - 15:47:34 EST


On Tue, Feb 02, 2016 at 12:09:22PM -0600, Mario Limonciello wrote:
>
>
> On 02/02/2016 11:32 AM, Darren Hart wrote:
> > On Mon, Feb 01, 2016 at 08:28:50PM -0600, Mario Limonciello wrote:
> >> This allows configuration the system for wakeup with a controller.
> > Hrm, I'm happy to clean up English grammar in commit messages... but I'm
> > struggling with the intent of the above... Is this correct:
> >
> > Allow for user configuration, via sysfs, for wakeup with a controller.
> >
> > If so, great - but also, what do we mean by "with a controller" ?
>
> I see how this is confusing to someone who isn't in the know what's
> going on.
> A better description is:
>
> Allow for user configuration of BIOS settings that allow the system to
> turned on via HID devices.
>
> If that's concise enough I'll update in next submission.

Yes, that's better. I think meant "... to be turned on ...". Otherwise, good.

Thanks,

--
Darren Hart
Intel Open Source Technology Center