Re: [PATCH] Staging: fix coding style in rtl8188eu/core

[Colin Vidal]

On Tue, 2016-02-02 at 23:54 +0100, Colin Vidal wrote:
> Set constant operand on right of test, and refactor the code in a
> more
> compact and readable way.
> 
> Signed-off-by: Colin Vidal <colin@xxxxxxxxxx>
> ---
> Âdrivers/staging/rtl8188eu/core/rtw_iol.c | 13 +++++--------
> Â1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c
> b/drivers/staging/rtl8188eu/core/rtw_iol.c
> index cdcf0ea..00e1136 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_iol.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
> @@ -18,14 +18,11 @@
> Â *
> Â
> *********************************************************************
> *********/
> Â
> -#include<rtw_iol.h>
> +#include <rtw_iol.h>
> Â
> -bool rtw_IOL_applied(struct adapterÂÂ*adapter)
> +bool rtw_IOL_applied(struct adapter *adapter)
> Â{
> -	if (1 == adapter->registrypriv.fw_iol)
> -		return true;
> -
> -	if ((2 == adapter->registrypriv.fw_iol) &&
> (!adapter_to_dvobj(adapter)->ishighspeed))
> -		return true;
> -	return false;
> +	return adapter->registrypriv.fw_iol == 1 ||
> +		(adapter->registrypriv.fw_iol == 2 &&
> +		Â!adapter_to_dvobj(adapter)->ishighspeed);
> Â}

Argh... The subject should be prefixed by "[PATCH v2]"... Missing
training, sorry.