Re: [PATCH RESEND] mailbox: pcc: fix channel calculation in get_pcc_channel()

[Rafael J. Wysocki]

On Tuesday, February 02, 2016 11:29:22 AM Alexey Klimov wrote:
> This patch fixes the calculation of pcc_chan for non-zero id.
> After the compiler ignores the (unsigned long) cast the
> pcc_mbox_channels pointer is type-cast and then the type-cast
> offset is added which results in address outside of the range
> leading to the kernel crashing.
> 
> We might add braces and make it:
> 
> pcc_chan = (struct mbox_chan *)
> 		((unsigned long) pcc_mbox_channels +
> 		(id * sizeof(*pcc_chan)));
> 
> but let's go with array approach here and use id as index.
> 
> Tested on Juno board.
> 
> Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> Acked-by: Ashwin Chaugule <ashwin.chaugule@xxxxxxxxxx>
> Signed-off-by: Alexey Klimov <alexey.klimov@xxxxxxx>

Jassi said this was applied, so I'm not taking it.

Thanks,
Rafael