Re: [RFC 00/26] perf tools: Introduce hists specific format entries

[Jiri Olsa]

On Wed, Feb 03, 2016 at 08:58:53AM +0100, Jiri Olsa wrote:
> On Tue, Feb 02, 2016 at 07:42:16PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Ok, so I rebased it on top of my perf/core branch, adjusting some stuff
> > > wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is
> > > no more, etc), and renaming that perf_hpp_list->{list,sort_list} to
> > > ->{fields,sorts} as Namhyung suggested and you agreed, it builds...
> > > 
> > > But perf top isn't showing the overhead column... there were some
> > > changes to perf report in this patchkit to move some initializations...
> > > will check there...
> > 
> > Fixed, doing the same change you made for 'perf report', moving the
> > setup_sorting call to after the setup_browser one, inserted a new patch
> > with that just before the patch where the problem was bisected, please
> > check.
> > 
> > To recap:
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tmp.perf/hists/hpp_list
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/hists/hpp_list&id=7d105448f8922679956728a7f5106218378c450e
> 
> I'll check on that, thanks a lot

it looks ok to me

thanks,
jirka