Re: [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE_*

[David Howells]

Borislav Petkov <bp@xxxxxxxxx> wrote:

> In file included from arch/x86/boot/mkcpustr.c:20:0:
> arch/x86/boot/../include/asm/cpufeatures.h:4:35: fatal error: asm/required-features.h: No such file or directory
> compilation terminated.
> make[1]: *** [arch/x86/boot/mkcpustr] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [bzImage] Error 2
> make: *** Waiting for unfinished jobs....
> 
> That's when you remove the #ifndef guards.
> 
> And I think the commit above does this special dancing to keep
> cpufeature.h a kernel-only header and not make it an uapi one. David, am
> I close?

Yes.  CONFIG_ symbols should be considered verboten in UAPI headers and
cpufeature.h is all about using them.

David