Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree

[Lubomir Rintel]

On Wed, 2016-02-03 at 16:02 +0100, Lubomir Rintel wrote:
> The hub and the ethernet in its port 1 are hardwired on the board.
> 
> Compared to the adapters that can be plugged into the USB ports, this
> one has no serial EEPROM to store its MAC. Nevertheless, the
> Raspberry Pi
> has the MAC address for this adapter in its ROM, accessible from its
> firmware.
> 
> U-Boot can read out the address and set the local-mac-address
> property of the
> node with "ethernet" alias. Let's add the node so that U-Boot can do
> its
> business.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> ---
> Âarch/arm/boot/dts/bcm2835-rpi-b-plus.dts | 18 ++++++++++++++++++
> Âarch/arm/boot/dts/bcm283x.dtsiÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ4 +++-
> Â2 files changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> index ef54050..32bbd2a 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> @@ -6,6 +6,10 @@
> Â	compatible = "raspberrypi,model-b-plus", "brcm,bcm2835";
> Â	model = "Raspberry Pi Model B+";
> Â
> +	aliases {
> +		ethernet = &ethernet;
> +	}

I'm missing a semicolon here. I'll follow up with an updated version
once I get some feedback.

> +
> Â	leds {
> Â		act {
> Â			gpios = <&gpio 47 0>;
> @@ -29,3 +33,17 @@
> Â		brcm,function = <BCM2835_FSEL_ALT0>;
> Â	};
> Â};
> +
> +&usb {
> +	usb1@01 {
> +		compatible = "usb1d6b,0002";
> +		reg = <01>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethernet: usbether@01 {
> +			compatible = "usb0424,9514";
> +			reg = <01>;
> +		};
> +	};
> +};
> diff --git a/arch/arm/boot/dts/bcm283x.dtsi
> b/arch/arm/boot/dts/bcm283x.dtsi
> index 971e741..bc5fde1 100644
> --- a/arch/arm/boot/dts/bcm283x.dtsi
> +++ b/arch/arm/boot/dts/bcm283x.dtsi
> @@ -187,10 +187,12 @@
> Â			status = "disabled";
> Â		};
> Â
> -		usb@7e980000 {
> +		usb: usb@7e980000 {
> Â			compatible = "brcm,bcm2835-usb";
> Â			reg = <0x7e980000 0x10000>;
> Â			interrupts = <1 9>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> Â		};
> Â	};
> Â