Re: [PATCH v6] SATA: OCTEON: support SATA on OCTEON platform

[Arnd Bergmann]

On Wednesday 03 February 2016 16:02:05 Zubair Lutfullah Kakakhel wrote:

> Hence, I find the original binding simpler and easier to understand when looking at the hardware manual
> 
> +       uctl@118006c000000 {
> +               compatible = "cavium,octeon-7130-sata-uctl";
> +               reg = <0x11800 0x6c000000 0x0 0x100>;
> +               ranges; /* Direct mapping */
> +               dma-ranges;
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +
> +               sata: sata@16c0000000000 {
> +                       compatible = "cavium,octeon-7130-ahci";
> +                       reg = <0x16c00 0x00000000 0x0 0x200>;
> +                       interrupt-parent = <&cibsata>;
> +                       interrupts = <2 4>; /* Bit: 2, level */
> +               };
> +       };
> 
> Is it possible to let this example go in as is?
> 

I don't have the hardware manual, so I'm just guessing what the hardware
looks like. If the manual describes the device as a bridge with a 1:1 mapping,
then your existing example above absolutely makes sense.

	Arnd