Re: [PATCH] mm/workingset: do not forget to unlock page

[Johannes Weiner]

On Wed, Feb 03, 2016 at 07:41:36PM +0900, Sergey Senozhatsky wrote:
> From 1d6315221f2f81c53c99f9980158f8ae49dbd582 Mon Sep 17 00:00:00 2001
> From: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> Date: Wed, 3 Feb 2016 18:49:16 +0900
> Subject: [PATCH] mm/workingset: do not forget to unlock_page in workingset_activation
> 
> Do not return from workingset_activation() with locked rcu and page.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

Thanks Sergey. Even though I wrote this function, my brain must have
gone "it can't be locking anything when it returns NULL, right?" It's
a dumb interface. Luckily, that's fixed with follow-up patches in -mm.

As for this one:

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
Fixes: mm: workingset: per-cgroup cache thrash detection

Andrew, can you please fold this?