Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency

[Felipe Balbi]

hi,

Bin Liu <b-liu@xxxxxx> writes:
> On Wed, Jan 20, 2016 at 11:56:34AM +0100, Arnd Bergmann wrote:
>> The phy-am335x driver accidentally selects 'USB_COMMON', which is
>> not correct as that symbol should indicate whether USB host or
>> target mode is enabled, but it might not:
>> 
>> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
>
> Is it possible to have a .config which has either USB nor USB_GADGET
> set but AM335X_PHY_USB is set to be in the situation as in the warning
> above?
>
>> 
>> This changes the 'select' into 'depends on', as it should have
>> been initially.
>
> Using 'depends on' causes AM335x_PHY_USB driver unable to built-in,
> since USB_COMMON is an invisible option and its defualt is 'M'.


yeah, USB_COMMON is supposed to be selected, not depended upon.

-- 
balbi

Attachment: signature.asc
Description: PGP signature