RE: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port

[Ofer Heifetz]

Hi Marcin,

I think it is a partial fix since once QA started to use this patch and found that /proc/interrupts prints serial interrupt string multiple times which is clobbering the print.

/Ofer


-----Original Message-----
From: Marcin Wojtas [mailto:mw@xxxxxxxxxxxx] 
Sent: Thursday, February 04, 2016 12:23 AM
To: Thomas Petazzoni; Ofer Heifetz
Cc: Gregory CLEMENT; Jason Cooper; Andrew Lunn; Sebastian Hesselbarth; arm@xxxxxxxxxx; Catalin Marinas; Will Deacon; Jonathan Corbet; Mark Rutland; devicetree@xxxxxxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; Greg Kroah-Hartman; Omri Itach; linux-kernel@xxxxxxxxxxxxxxx; Nadav Haklai; Hans de Goede; Lior Amsalem; linux-serial@xxxxxxxxxxxxxxx; Jiri Slaby; Tejun Heo; Wilson Ding; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port

I'm sorry, indeed, I was the one to overlook - there was a lot going on in a thread and I missed it.

Ofer, as you found out that IRQF_SHARED help booting ubuntu - do you think it's a hack or fix?

Best regards,
Marcin

2016-02-03 23:02 GMT+01:00 Thomas Petazzoni
<thomas.petazzoni@xxxxxxxxxxxxxxxxxx>:
> Dear Marcin Wojtas,
>
> On Wed, 3 Feb 2016 22:41:15 +0100, Marcin Wojtas wrote:
>> Hi Gregory,
>>
>> > +       port->irq        = irq->start;
>> > +       port->irqflags   = 0;
>>
>> Same request as for v1, which you must have overlooked:
>> port->irqflags = IRQF_SHARED;
>
> Gregory didn't overlook this comment you made on v1, he even replied 
> to it. Please check Gregory's reply to your review.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering 
> http://free-electrons.com