Re: [RFT PATCH] arm: omap1_defconfig: convert to use libata PATA drivers
From: Bartlomiej Zolnierkiewicz
Date: Thu Feb 04 2016 - 09:16:47 EST
Hi,
On Sunday, August 16, 2015 11:34:55 PM Tony Lindgren wrote:
> * Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> [150814 10:10]:
> > IDE subsystem has been deprecated since 2009 and the majority
> > (if not all) of Linux distributions have switched to use
> > libata for ATA support exclusively. However there are still
> > some users (mostly old or/and embedded non-x86 systems) that
> > have not converted from using IDE subsystem to libata PATA
> > drivers. This doesn't seem to be good thing in the long-term
> > for Linux as while there is less and less PATA systems left
> > in use:
> >
> > * testing efforts are divided between two subsystems
> >
> > * having duplicate drivers for same hardware confuses users
> >
> > This patch converts omap1_defconfig to use libata PATA
> > drivers.
> >
> > Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> > Cc: linux-omap@xxxxxxxxxxxxxxx
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> > ---
> > Build tested only.
> > If you have affected hardware please test. Thank you.
>
> All my omap1 devices are in a rack using NFSroot or MMC so
> I can't test this. Seems like a good idea to me thoug, and does
> not cause merge conflicts. So if you want to queue this via
> along with other PATA related patches, please feel free to
> add:
>
> Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
Thank you.
Arnd/Olof, could you please merge this patch?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> > arch/arm/configs/omap1_defconfig | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/configs/omap1_defconfig b/arch/arm/configs/omap1_defconfig
> > index 0c8a787..6ffc984 100644
> > --- a/arch/arm/configs/omap1_defconfig
> > +++ b/arch/arm/configs/omap1_defconfig
> > @@ -96,14 +96,14 @@ CONFIG_BLK_DEV_LOOP=y
> > CONFIG_BLK_DEV_RAM=y
> > CONFIG_BLK_DEV_RAM_COUNT=2
> > CONFIG_BLK_DEV_RAM_SIZE=8192
> > -CONFIG_IDE=m
> > -CONFIG_BLK_DEV_IDECS=m
> > CONFIG_SCSI=y
> > # CONFIG_SCSI_PROC_FS is not set
> > CONFIG_BLK_DEV_SD=y
> > CONFIG_CHR_DEV_ST=y
> > CONFIG_BLK_DEV_SR=y
> > CONFIG_CHR_DEV_SG=y
> > +CONFIG_ATA=m
> > +CONFIG_PATA_PCMCIA=m
> > CONFIG_NETDEVICES=y
> > CONFIG_TUN=y
> > CONFIG_PHYLIB=y