Re: [PATCH] dax: dirty inode only if required

[Ross Zwisler]

On Thu, Feb 04, 2016 at 03:33:44PM +0100, Jan Kara wrote:
> On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote:
> > 
> > Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
> 
> Makes sense. You can add:
> 
> Reviewed-by: Jan Kara <jack@xxxxxxx>

Looks good to me as well.

Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>

> 								Honza
> > ---
> >  fs/dax.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/dax.c b/fs/dax.c
> > index e0e9358..fc2e314 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
> >  	void *entry;
> >  
> >  	WARN_ON_ONCE(pmd_entry && !dirty);
> > -	__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> > +	if (dirty)
> > +		__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> >  
> >  	spin_lock_irq(&mapping->tree_lock);
> >  
> > -- 
> > 1.8.3.1
> > 
> -- 
> Jan Kara <jack@xxxxxxxx>
> SUSE Labs, CR