Re: [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally

[Javier Martinez Canillas]

Hello Laxman,

On 02/03/2016 11:50 PM, Laxman Dewangan wrote:

[snip]

> > > >
> > > Looks good and works properly (RTC, unbind/rebind, wakealarm again)
> > > but... after applying this patch the device cannot suspend to RAM after
> > > unbind/rebind.
> > >
> > > Reproduce path, after booting:
> > > $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/unbind
> > > $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/bind
> > > $ rtcwake -d rtc2 -m mem -s 5 -v
> > > (or instead of rtcwake: echo mem > /sys/power/state)
>
> Can you please also try to test in your setup which have MAX77802?
> On this, we do not create i2c client and do regmap_init_i2c. So may be it helps on narrow down the issue.

Sorry for the delay but I was busy with others tasks. I've tested it
on an Exynos5800 Peach Pi (which has a max77802) and I've the same
issue. The system doesn't suspend after the max77802-rc unbind.

As Krzysztof narrowed down, commenting the regmap_del_irq_chip() call
in the .remove callback makes it to not fail again.

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America