Re: [PATCH 0/2] Radix tree retry bug fix & test case

[Konstantin Khlebnikov]

On Fri, Feb 5, 2016 at 6:40 AM, Matthew Wilcox
<matthew.r.wilcox@xxxxxxxxx> wrote:
> Konstantin pointed out my braino when using radix_tree_iter_retry(),
> and then pointed out a second braino.  I think we can fix both brainos
> with one simple test (the advantage of having your braino pointed out
> to you is that you know what you were expecting to happen, so you can
> sometimes propose simlpy making happen what you expected to happen.
> Konstantin doesn't have access to my though tprocesses.)
>
> Kontantin wrote a really great test ... and then didn't add it to the
> test suite.  That made me sad, so I added it.

I haven't seen them, I wasn't in CC. And I prefer testing in vivo if possible.

>
> Andrew, can you drop radix-tree-fix-oops-after-radix_tree_iter_retry.patch
> from your tree and add these two patches instead?  If you prefer
> Konstantin's fix to this one, I'll send you another patch to fix the
> second problem Konstantin pointed out.

Nak. Mine version generates better code. radix_tree_next_slot is a hot place.
Please fix second problem in your helper separately.

>
> I was a bit unsure about the proper attribution here.  The essentials
> of the test-suite change from Konstantin are unchanged, but he didn't
> have his own sign-off on it.  So I made him 'From' and only added my
> own sign-off.
>
> Konstantin Khlebnikov (1):
>   radix-tree tests: Add regression3 test
>
> Matthew Wilcox (1):
>   radix-tree: fix oops after radix_tree_iter_retry
>
>  include/linux/radix-tree.h              |  3 ++
>  tools/testing/radix-tree/Makefile       |  2 +-
>  tools/testing/radix-tree/linux/kernel.h |  1 +
>  tools/testing/radix-tree/main.c         |  1 +
>  tools/testing/radix-tree/regression.h   |  1 +
>  tools/testing/radix-tree/regression3.c  | 86 +++++++++++++++++++++++++++++++++
>  6 files changed, 93 insertions(+), 1 deletion(-)
>  create mode 100644 tools/testing/radix-tree/regression3.c
>
> --
> 2.7.0.rc3
>