Re: [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral

[Sergei Shtylyov]

Hello.

On 2/5/2016 8:08 AM, Purna Chandra Mandal wrote:

> > > From: Purna Chandra Mandal <purna.mandal@xxxxxxxxxxxxx>
> > > Document the devicetree bindings for the SPI peripheral found
> > > on Microchip PIC32 class devices.
> > > Signed-off-by: Purna Chandra Mandal <purna.mandal@xxxxxxxxxxxxx>
> > > Signed-off-by: Joshua Henderson <joshua.henderson@xxxxxxxxxxxxx>
> > > ---
> > >    .../bindings/spi/microchip,spi-pic32.txt           |   44 ++++++++++++++++++++
> > >    1 file changed, 44 insertions(+)
> > >    create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
> > > diff --git a/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
> > > new file mode 100644
> > > index 0000000..a555618
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
> > > @@ -0,0 +1,44 @@
> > > +* Microchip PIC32 SPI device

[...]

> > > +Example:
> > > +
> > > +    spi1:spi@0x1f821000 {
> > Please insert spaces after colon.

> ack

   And please drop "0x" from the <unit-address> part of the name.

MBR, Sergei