RE: [PATCH] PCI: layerscape: add ls2085a compatible

From: Yang-Leo Li
Date: Fri Feb 05 2016 - 16:12:38 EST


> On Fri, Feb 05, 2016 at 06:07:10AM +0000, Minghuan Lian wrote:
> > The patch is ok to me.
>
> Thanks, I'll transform that into an ack.

Also
Acked-by: Li Yang <leoyang.li@xxxxxxx>

>
> Who's going to post a patch to update MAINTAINERS to fix the @freescale.com
> addresses? If we can get that in for v4.5, it will save some hassle.

The @freescale.com address can still reach us for some time(not sure how long though). I don't know if all the people want to change to an NXP company email address in MAINTAINERS or just update to a personal email address as some already did.

Regards,
Leo

>
> > > -----Original Message-----
> > > From: Bhupesh Sharma
> > > Sent: Friday, February 05, 2016 1:36 PM
> > > To: Shi, Yang <yang.shi@xxxxxxxxxx>; Bjorn Helgaas
> > > <helgaas@xxxxxxxxxx>; Yang-Leo Li <leoyang.li@xxxxxxx>;
> > > shawn.guo@xxxxxxxxxx
> > > Cc: Mingkai Hu <mingkai.hu@xxxxxxx>; Minghuan Lian
> > > <minghuan.lian@xxxxxxx>; bhelgaas@xxxxxxxxxx;
> > > linux-pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > > linaro-kernel@xxxxxxxxxxxxxxxx
> > > Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible
> > >
> > > > From: Shi, Yang
> > > > Sent: Friday, February 05, 2016 5:19 AM
> > > >
> > > > On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
> > > > > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
> > > > >> Correct FSL folks email address to nxp.com, sorry for the
> > > > inconvenience.
> > > > >
> > > > > Do we need some MAINTAINERS updates in addition to the ack for
> > > > > this
> > > > patch?
> > > > > I see a bunch of @freescale.com addresses in MAINTAINERS.
> > > >
> > > > I guess so if the @freescale.com address is not valid anymore.
> > >
> > > All @freescale.com address have shifted to @nxp.com.
> > >
> > > Leo, Minghuan - can you kindly review this patch.
> > >
> > > Shawn - can you take this through your tree, once Leo and Minghuan
> > > have reviewed the code.
> > >
> > > Regards,
> > > Bhupesh
> > >
> > > >
> > > > >
> > > > >> On 1/27/2016 9:32 AM, Yang Shi wrote:
> > > > >>> The layerscape PCI host driver needs recognize ls2085a
> > > > >>> compatible when using firmware with ls2085a compatible
> > > > >>> property, otherwise the PCI bus won't be detected even though
> > > > >>> ls2085a compatible is included
> > > > by the dts.
> > > > >>>
> > > > >>> Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxx>
> > > > >>> ---
> > > > >>> drivers/pci/host/pci-layerscape.c | 1 +
> > > > >>> 1 file changed, 1 insertion(+)
> > > > >>>
> > > > >>> diff --git a/drivers/pci/host/pci-layerscape.c
> > > > >>> b/drivers/pci/host/pci-layerscape.c
> > > > >>> index 3923bed..c40d8b2 100644
> > > > >>> --- a/drivers/pci/host/pci-layerscape.c
> > > > >>> +++ b/drivers/pci/host/pci-layerscape.c
> > > > >>> @@ -203,6 +203,7 @@ static const struct of_device_id
> > > > ls_pcie_of_match[] = {
> > > > >>> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
> > > > },
> > > > >>> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
> > > > },
> > > > >>> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
> > > > },
> > > > >>> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata
> > > > >>> +},
> > > > >>> { },
> > > > >>> };
> > > > >>> MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
> > > > >>>
> > > > >>
> > > >
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe linux-pci"
> > > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More
> > > > majordomo info at http://vger.kernel.org/majordomo-info.html