Re: [PATCH] devm_memremap: Fix error value when memremap failed

From: Dan Williams
Date: Fri Feb 05 2016 - 20:52:10 EST


On Fri, Feb 5, 2016 at 5:49 PM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> On Fri, Feb 5, 2016 at 5:40 PM, Toshi Kani <toshi.kani@xxxxxxx> wrote:
>> devm_memremap() returns an ERR_PTR() value in case of error.
>> However, it returns NULL when memremap() failed. This causes
>> the caller, such as the pmem driver, to proceed and oops later.
>>
>> Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap()
>> failed.
>>
>> Signed-off-by: Toshi Kani <toshi.kani@xxxxxxx>
>> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
>> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
> Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Should also go to -stable, I'll add that and include this with some
other fixes I have brewing.