Re: [PATCH v6 3/3] gpio: tps65086: Add GPO driver for the TPS65086 PMIC

[Andrew F. Davis]

On 02/05/2016 08:43 AM, Linus Walleij wrote:
> On Mon, Jan 25, 2016 at 4:50 PM, Andrew F. Davis <afd@xxxxxx> wrote:
>
> > Add support for the TPS65086 PMIC GPOs.
> >
> > TPS65086 has four configurable GPOs that can be used for several
> > purposes. These are output only.
> >
> > Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> (...)
> > +static inline struct tps65086_gpio *to_tps65086_gpio(struct gpio_chip *chip)
> > +{
> > +       return container_of(chip, struct tps65086_gpio, chip);
> > +}
>
> Remove this and use gpiochip_get_data() instead.
>
> > +       ret = gpiochip_add(&gpio->chip);
>
> And use gpiochip_add_data() to pass what gpiochip_get_data()
> will return.
>
> Apart from that no strong opinions.
>
> If there is a header file dependency this either has to go to
> Lee's tree with my ACK, or wait until the next kernel cycle.
> But first change the above.
>
> Yours,
> Linus Walleij

Changes made, I will resend this part as its own patch as the other components
have been taken.

Thanks,
Andrew