Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap, irq chip locally

From: Alexandre Belloni
Date: Mon Feb 08 2016 - 05:42:17 EST


On 08/02/2016 at 15:50:06 +0530, Laxman Dewangan wrote :
>
> On Saturday 06 February 2016 08:07 PM, Laxman Dewangan wrote:
> >- ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL,
> >- max77686_rtc_alarm_irq, 0,
> >- "rtc-alarm1", info);
> >- if (ret < 0)
> >+ ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
> >+ "rtc-alarm1", info);
> >+ if (ret < 0) {
> > dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
> > info->virq, ret);
> >+ goto err_rtc;
> >+ }
> >+
> >+ return 0;
> > err_rtc:
>
> Oops.. I wish I should have called regmap_irq_put_virq(info->virq); here.
>
> Please let me know if I can respin this patch only instead of entire series.
>

Sure, you can.

>

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com