Re: [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug ()
From: Ingo Molnar
Date: Mon Feb 08 2016 - 06:18:18 EST
* PaX Team <pageexec@xxxxxxxxxxx> wrote:
> On 8 Feb 2016 at 1:42, tip-bot for Ingo Molnar wrote:
>
> > for (i = 0; i < numa_meminfo.nr_blks; i++) {
> > - struct numa_memblk *mb = &numa_meminfo.blk[i];
> > + struct numa_memblk *mb = numa_meminfo.blk + i;
> >
> > - memblock_set_node(mb->start, mb->end - mb->start,
> > - &memblock.reserved, mb->nid);
> > + memblock_set_node(mb->start, mb->end-mb->start, &memblock.reserved, mb->nid);
>
> if you're not keeping to the 80-char length (no complaints from me on that), could
> you also use some whitespace around the '-' operator for more readability?
Yeah, like I did it later in the function:
+ memblock_clear_hotplug(mb->start, mb->end - mb->start);
Fixed.
Thanks,
Ingo