Re: [PATCH] drm/exynos: dp: Fix panel and bridge lookup logic

[Javier Martinez Canillas]

Hello Marek,

On 02/08/2016 09:38 AM, Marek Szyprowski wrote:
> Hi Javier,
>
> On 2016-02-08 13:03, Javier Martinez Canillas wrote:
> > Hello Inki,
> >
> > On 01/29/2016 12:09 PM, Javier Martinez Canillas wrote:
> > > Commit a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support
> > > for panel") made the Exynos DP DT binding more consistent since the OF
> > > graph could be used to lookup either a panel or a bridge device node.
> > >
> > > Before that commit, a panel would be looked up using a phandle and a
> > > bridge using the OF graph which made the DT binding not consistent.
> > >
> > > But the patch broke the later case since not finding a panel dev node
> > > would cause the driver's to do a probe deferral instead of attempting
> > > to lookup a bridge device node associated with the remote endpoint.
> > >
> > > So instead of returning a -EPROBE_DEFER if a panel is not found, check
> > > if there's a bridge and only do a probe deferral if both aren't found.
> > >
> > > Fixes: a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support for panel")
> > > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> >
> > Any comments about this patch? It is needed to have display working on
> > machines with a bridge chip again so it should be pushed to -rc ASAP.
>
> Please check v4.5-rc3, this patch is already merged there.

My bad, I was looking at v4.5-rc2 and Inki used to answer to patches
when he picks them so I thought he didn't have time to look at it yet.

Anyways, thanks a lot for pointing it out.
 
> Best regards

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America