Re: [PATCH] net: am79c961a: avoid %? in inline assembly

From: Russell King - ARM Linux
Date: Mon Feb 08 2016 - 10:46:20 EST


On Mon, Feb 08, 2016 at 03:33:42PM +0100, Arnd Bergmann wrote:
> The am79c961a.c driver fails to build with clang because of an
> unusual inline assembly construct:
>
> drivers/net/ethernet/amd/am79c961a.c:53:7: error: invalid % escape in inline assembly string
> "str%?h %1, [%2] @ NET_RAP\n\t"
>
> The same change has been done a decade ago in arch/arm as of
> 6a39dd6222dd ("[ARM] 3759/2: Remove uses of %?"), but apparently
> some drivers were missed.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>

Thanks Arnd.

--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.