Re: [PATCH V3 03/13] cpufreq: governor: New sysfs show/store callbacks for governor tunables

From: Viresh Kumar
Date: Mon Feb 08 2016 - 22:21:35 EST


On 08-02-16, 22:36, Rafael J. Wysocki wrote:
> On Mon, Feb 8, 2016 at 12:39 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > + ret = kobject_init_and_add(&dbs_data->kobj, &gov->kobj_type,
> > + get_governor_parent_kobj(policy),
> > + gov->kobj_name);
>
> Besides, you forgot about the format argument for kobject_init_and_add().

What about that? Why is it required here ? We don't have to modify the
gov->gov.name string at all, and that string can be used here without adding any
more format arguments.

--
viresh