Re: [PATCH 3/6] ARM: sunxi_defconfig: Enable MUSB HDRC driver with Allwinner glue

From: Chen-Yu Tsai
Date: Tue Feb 09 2016 - 03:27:34 EST


On Tue, Feb 9, 2016 at 4:15 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> On Sat, Feb 06, 2016 at 11:53:46PM +0800, Chen-Yu Tsai wrote:
>> Allwinner SoCs typically have a Mentor Graphics Inventra MUSB dual role
>> controller for USB OTG.
>>
>> Now that the issue with MUSB and USB gadget registration order has been
>> resolved, we can enable this driver in dual role mode. This requires the
>> NOP USB transceiver driver, which is also enabled.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
>> ---
>> arch/arm/configs/sunxi_defconfig | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
>> index efa12c88fe1c..e29b81694184 100644
>> --- a/arch/arm/configs/sunxi_defconfig
>> +++ b/arch/arm/configs/sunxi_defconfig
>> @@ -109,6 +109,11 @@ CONFIG_USB_EHCI_HCD=y
>> CONFIG_USB_EHCI_HCD_PLATFORM=y
>> CONFIG_USB_OHCI_HCD=y
>> CONFIG_USB_OHCI_HCD_PLATFORM=y
>> +CONFIG_USB_MUSB_HDRC=y
>> +CONFIG_USB_MUSB_SUNXI=y
>> +CONFIG_NOP_USB_XCEIV=y
>> +CONFIG_USB_GADGET=y
>> +CONFIG_USB_CDC_COMPOSITE=y
>
> I'd prefer not to have any default gadget here, just like you did on
> multi_v7.

FYI the default here (in Kconfig) would be CONFIG_USB_ETH
"Ethernet Gadget (with CDC Ethernet support)".

CDC_COMPOSITE (CDC Ethernet + serial) is somewhat more useful.
But I'll change it.

ChenYu