Re: [PATCH v3 0/2] Consolidate redundant register/stack access code

From: Ingo Molnar
Date: Tue Feb 09 2016 - 04:45:45 EST



* Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:

> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote:
>
> > From: "David A. Long" <dave.long@xxxxxxxxxx>
> >
> > Move duplicate and functionally equivalent code for accessing registers
> > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into
> > common kernel files.
> >
> > I'm sending this out again (with updated distribution list) because v2
> > just never got pulled in, even though I don't think there were any
> > outstanding issues.
>
> A big cross arch patch like this would often get taken by Andrew Morton, but
> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for
> us :D

The other problem is that the second patch is commingling changes to 6 separate
architectures:

16 files changed, 106 insertions(+), 343 deletions(-)

that should probably be 6 separate patches. Easier to review, easier to bisect to,
easier to revert, etc.

Thanks,

Ingo