Re: [PATCH v2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy
From: Ingo Molnar
Date: Tue Feb 09 2016 - 06:27:40 EST
* Borislav Petkov <bp@xxxxxxx> wrote:
> On Tue, Feb 09, 2016 at 11:27:41AM +0100, Ingo Molnar wrote:
> > So another pet peeve of mine is to not use numeric labels, please use
> > descriptively named labels instead.
>
> ... and prepend them with ".L" so that they become local labels.
Yes. A good example to follow would be arch/x86/entry/entry_64.S.
Btw., IIRC GAS is being silly about .L, i.e. there's a difference between these
two variants:
.Lerror_entry_from_usermode_swapgs:
.L_error_entry_from_usermode_swapgs:
the latter would be easier to read, but does not result in a local label last I
checked.
Right?
Thanks,
Ingo