Re: [PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver

From: Timur Tabi
Date: Tue Feb 09 2016 - 12:39:36 EST


fu.wei@xxxxxxxxxx wrote:

+ if (!action)
+ dev_warn(dev, "fall back to signle stage mode.\n");

"falling back to single stage mode"

Acked-by: Timur Tabi <timur@xxxxxxxxxxxxxx>

The whole "calculate the timeouts different if 'action' is enabled" seems clunky to me, but I can't think of a better way to handle it.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.