Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level>
From: Joe Perches
Date: Tue Feb 09 2016 - 18:53:16 EST
On Tue, 2016-02-09 at 10:57 +0100, Ingo Molnar wrote:
> * Chen Yucong <slaoub@xxxxxxxxx> wrote:
>
> > arch/x86/kernel/* use a mixture of printk(KERN_ ) and pr_().
> > This patch converts the bulk of printk(KERN_ ) to pr_() and
> > uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning()
> > calls have been replaced with pr_warn().
> >
> > Not sure what to do about the printk(KERN_DEFAULT) and printk() without a
> > log level.
> >
> > Signed-off-by: Chen Yucong <slaoub@xxxxxxxxx>
>
> When converting please also join broken up format strings, such as:
>
> - printk(KERN_WARNING PREFIX
> - "HPET id: %#x base: 0xfed0000000000000 fixed up "
> - "to 0xfed00000.\n", hpet_tbl->id);
> + pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up "
> + "to 0xfed00000.\n", hpet_tbl->id);
>
> ignore checkpatch: we don't line-break user visible strings.
Umm, checkpatch already suggests to coalesce split strings.
ie:
WARNING: quoted string split across lines
#850: FILE: arch/x86/kernel/hpet.c:850:
+ "HPET config register value = 0xFFFFFFFF. "
+ "Disabling HPET\n");
and checkpatch does the fixing using something like:
$ ./scripts/checkpatch.pl -f --fix-inplace --types=split_string arch/x86/kernel/hpet.c