Re: [PATCH v2] staging: unisys: use common return path
From: Sudip Mukherjee
Date: Wed Feb 10 2016 - 00:12:43 EST
On Mon, Feb 08, 2016 at 10:46:57PM +0530, Sudip Mukherjee wrote:
> On Sun, Feb 07, 2016 at 02:04:21PM -0800, Greg Kroah-Hartman wrote:
> > On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote:
> > > The success path and the error path both are first doing
> > > spin_unlock_irqrestore() before returning. Use that in the common path
> > > and return the success/error value.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> > > ---
> > >
> > > v2: changed label name
> > >
> > > It is dependent on the patch series sent by Benjamin (Nov 30th).
> >
> > Which didn't get applied, so can you resend this after that does get
> > accepted?
>
> oops, i dont think i have the patch anymore. But looking at the commit
> message, i think i just sent the same suggestion to Benjamin for his
> [PATCH v3 13/14] staging: unisys: fix else statement in visornic_main.c
>
> If he is not changing then I will create the patch and send you.
Hi Greg,
I will not be resending this patch as Ben is against to using goto.
regards
sudip