Re: [PATCH] tty: add Moxa Smartio MUE serial driver
From: Andy Shevchenko
Date: Wed Feb 10 2016 - 01:32:51 EST
On Tue, Feb 9, 2016 at 2:10 PM, Mathieu OTHACEHE <m.othacehe@xxxxxxxxx> wrote:
>> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In
>> which case why not to use 8250_core.c / 8250_port.c and entire 8250/
>> infrastructure?
>
> Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie.
> The mxser driver has been cleaned up and integrated to mainline a long time ago (drivers/tty/mxser.c).
> I'm trying to do the same thing with the mxupcie driver.
>
> mxser and mxupcie are quite similar, maybe both should use 8250 infrastructure and not
> have independant drivers ?
Might be. Though for new driver it would be much easier to do.
After that someone might move the existing driver.
--
With Best Regards,
Andy Shevchenko