Re: [PATCH] regulator: ltc3589: Make IRQ optional

From: Philipp Zabel
Date: Wed Feb 10 2016 - 04:44:31 EST


Am Dienstag, den 09.02.2016, 21:14 +0100 schrieb Bernhard Walle:
> It's perfectly valid to use the LTC3589 without an interrupt pin
> connected to it. Currently, the driver probing fails when client->irq
> is 0 (which means "no interrupt"). Don't register the interrupt
> handler in that case but successfully finish the device probing instead.
>
> Signed-off-by: Bernhard Walle <bernhard@xxxxxxxxx>

Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

I suggest these small changes:

[...]
> @@ -520,12 +520,14 @@ static int ltc3589_probe(struct i2c_client *client,
> }
> }
>
> - ret = devm_request_threaded_irq(dev, client->irq, NULL, ltc3589_isr,
> - IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> - client->name, ltc3589);
> - if (ret) {
> - dev_err(dev, "Failed to request IRQ: %d\n", ret);
> - return ret;
> + if (client->irq != 0) {

How about using
if (client->irq) {
here ...

> + ret = devm_request_threaded_irq(dev, client->irq, NULL, ltc3589_isr,

... and reflowing this ...

> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> + client->name, ltc3589);
> + if (ret) {
> + dev_err(dev, "Failed to request IRQ %d: %d\n", client->irq, ret);

... and this long line.

regards
Philipp